From 1585a7a0adf2ac4058d79e8a1b036c5eae6f850c Mon Sep 17 00:00:00 2001 From: Robo Date: Wed, 30 Dec 2015 10:46:22 +0530 Subject: [PATCH] browser: provide localized string from resourcebundle --- atom.gyp | 32 +++----------------------------- atom/app/atom_content_client.cc | 5 +++++ atom/app/atom_content_client.h | 1 + 3 files changed, 9 insertions(+), 29 deletions(-) diff --git a/atom.gyp b/atom.gyp index 3f76dd4613ef..83605eedbc0d 100644 --- a/atom.gyp +++ b/atom.gyp @@ -121,10 +121,6 @@ ], }], ], - }, { # OS=="mac" - 'dependencies': [ - 'make_locale_paks', - ], }], # OS!="mac" ['OS=="win"', { 'include_dirs': [ @@ -155,6 +151,7 @@ 'destination': '<(PRODUCT_DIR)', 'files': [ '<@(copied_libraries)', + '<(libchromiumcontent_dir)/locales', '<(libchromiumcontent_dir)/libEGL.dll', '<(libchromiumcontent_dir)/libGLESv2.dll', '<(libchromiumcontent_dir)/icudtl.dat', @@ -203,6 +200,7 @@ 'destination': '<(PRODUCT_DIR)', 'files': [ '<@(copied_libraries)', + '<(libchromiumcontent_dir)/locales', '<(libchromiumcontent_dir)/icudtl.dat', '<(libchromiumcontent_dir)/content_shell.pak', '<(libchromiumcontent_dir)/natives_blob.bin', @@ -434,6 +432,7 @@ 'mac_bundle': 1, 'mac_bundle_resources': [ 'atom/common/resources/mac/MainMenu.xib', + '<(libchromiumcontent_dir)/locales', '<(libchromiumcontent_dir)/content_shell.pak', '<(libchromiumcontent_dir)/icudtl.dat', '<(libchromiumcontent_dir)/natives_blob.bin', @@ -546,31 +545,6 @@ }, }, # target helper ], - }, { # OS=="mac" - 'targets': [ - { - 'target_name': 'make_locale_paks', - 'type': 'none', - 'actions': [ - { - 'action_name': 'Make Empty Paks', - 'inputs': [ - 'tools/make_locale_paks.py', - ], - 'outputs': [ - '<(PRODUCT_DIR)/locales' - ], - 'action': [ - 'python', - 'tools/make_locale_paks.py', - '<(PRODUCT_DIR)', - '<@(locales)', - ], - 'msvs_cygwin_shell': 0, - }, - ], - }, - ], }], # OS!="mac" ], } diff --git a/atom/app/atom_content_client.cc b/atom/app/atom_content_client.cc index 997f66447ce9..25e9d0f1932a 100644 --- a/atom/app/atom_content_client.cc +++ b/atom/app/atom_content_client.cc @@ -20,6 +20,7 @@ #include "content/public/common/user_agent.h" #include "ppapi/shared_impl/ppapi_permissions.h" #include "third_party/widevine/cdm/stub/widevine_cdm_version.h" +#include "ui/base/l10n/l10n_util.h" #include "url/url_constants.h" #if defined(WIDEVINE_CDM_AVAILABLE) && defined(ENABLE_PEPPER_CDMS) @@ -175,6 +176,10 @@ std::string AtomContentClient::GetUserAgent() const { ATOM_PRODUCT_NAME "/" ATOM_VERSION_STRING); } +base::string16 AtomContentClient::GetLocalizedString(int message_id) const { + return l10n_util::GetStringUTF16(message_id); +} + void AtomContentClient::AddAdditionalSchemes( std::vector* standard_schemes, std::vector* savable_schemes) { diff --git a/atom/app/atom_content_client.h b/atom/app/atom_content_client.h index 76ac37642a71..33dbe19d990e 100644 --- a/atom/app/atom_content_client.h +++ b/atom/app/atom_content_client.h @@ -22,6 +22,7 @@ class AtomContentClient : public brightray::ContentClient { // content::ContentClient: std::string GetProduct() const override; std::string GetUserAgent() const override; + base::string16 GetLocalizedString(int message_id) const override; void AddAdditionalSchemes( std::vector* standard_schemes, std::vector* savable_schemes) override;