diff --git a/docs/development/upgrading-node.md b/docs/development/upgrading-node.md index 3ced87209ae4..227ecf141689 100644 --- a/docs/development/upgrading-node.md +++ b/docs/development/upgrading-node.md @@ -39,9 +39,9 @@ So in short, the primary steps are: ## Updating Electron's Node [fork](https://github.com/electron/node) 1. Ensure that `master` on `electron/node` has updated release tags from `nodejs/node` -1. Create a branch in https://github.com/electron/node: `electron-node-vX.X.X` where the base that you're branching from is the tag for the desired update +2. Create a branch in https://github.com/electron/node: `electron-node-vX.X.X` where the base that you're branching from is the tag for the desired update - `vX.X.X` Must use a version of node compatible with our current version of chromium -2. Re-apply our commits from the previous version of node we were using (`vY.Y.Y`) to `v.X.X.X` +3. Re-apply our commits from the previous version of node we were using (`vY.Y.Y`) to `v.X.X.X` - Check release tag and select the range of commits we need to re-apply - Cherry-pick commit range: 1. Checkout both `vY.Y.Y` & `v.X.X.X`