From 6eed4a98ceb48cb048777d9515586f76aa276476 Mon Sep 17 00:00:00 2001 From: Samuel Attard Date: Fri, 28 Jun 2019 14:37:00 -0700 Subject: [PATCH] fix: do not remove node globals when context isolation is enabled (#18967) --- lib/renderer/init.ts | 19 +++++++++++-------- 1 file changed, 11 insertions(+), 8 deletions(-) diff --git a/lib/renderer/init.ts b/lib/renderer/init.ts index 13b396a3691e..c181abfeba6c 100644 --- a/lib/renderer/init.ts +++ b/lib/renderer/init.ts @@ -179,14 +179,17 @@ if (nodeIntegration) { } } } else { - // Delete Node's symbols after the Environment has been loaded. - process.once('loaded', function () { - delete global.process - delete global.Buffer - delete global.setImmediate - delete global.clearImmediate - delete global.global - }) + // Delete Node's symbols after the Environment has been loaded in a + // non context-isolated environment + if (!contextIsolation) { + process.once('loaded', function () { + delete global.process + delete global.Buffer + delete global.setImmediate + delete global.clearImmediate + delete global.global + }) + } } const errorUtils = require('@electron/internal/common/error-utils')