fix: validate printToPDF margins against pageSize (#41157)

fix: validate margins against pageSize
This commit is contained in:
Shelley Vohr 2024-01-31 10:48:41 +01:00 committed by GitHub
parent 85bebfb180
commit 6df3443617
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 25 additions and 1 deletions

View file

@ -2053,6 +2053,20 @@ describe('webContents module', () => {
}
});
it('rejects when margins exceed physical page size', async () => {
await w.loadURL('data:text/html,<h1>Hello, World!</h1>');
await expect(w.webContents.printToPDF({
pageSize: 'Letter',
margins: {
top: 100,
bottom: 100,
left: 5,
right: 5
}
})).to.eventually.be.rejectedWith('margins must be less than or equal to pageSize');
});
it('does not crash when called multiple times in parallel', async () => {
await w.loadURL('data:text/html,<h1>Hello, World!</h1>');