refactor: clean up webFrame implementation to use gin wrappers (#28497)

Browse source

* refactor: clean up webFrame implementation to use gin wrappers

The previous implementation of webFrame in the renderer process leaked
sub-frame contexts and global objects across the context boundaries thus
making it possible for apps to either maliciously or accidentally
violate the contextIsolation boundary.

This re-implementation binds all methods in native code directly to
content::RenderFrame instances instead of relying on JS to provide a
"window" with every method request.  This is much more consistent with
the rest of the Electron codebase and is substantially safer.

* chore: un-re-order for ease of review

* chore: pass isolate around instead of ErrorThrower

* chore: fix rebase typo

* chore: remove unused variables

...

This commit is contained in:

Samuel Attard 2021-04-12 16:35:18 -07:00 • committed by GitHub

parent e775467e9c

commit 6df2680cb6

No known key found for this signature in database

GPG key ID: 4AEE18F83AFDEB23

8 changed files with 604 additions and 632 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

1087

shell/renderer/api/electron_api_web_frame.cc

View file

File diff suppressed because it is too large Load diff