mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

Merge pull request #7234 from Mossop/testhistoryreplace

Browse source 
✅ Test that replacement history entries don't break forward navigation.
This commit is contained in:
Cheng Zhao 2016-09-19 15:47:30 +09:00 committed by GitHub
commit 6de1eef078
2 changed files with 57 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
spec/fixtures/pages/history-replace.html vendored Normal file
View file

@ -0,0 +1,10 @@
<html>
<body>
<script type="text/javascript" charset="utf-8">
window.addEventListener("load", function() {
window.history.replaceState(window.history.state, "test page", window.location.href)
require('electron').ipcRenderer.sendToHost('history', window.history.length);
})
</script>
</body>
</html>

47
spec/webview-spec.js
View file

@ -623,6 +623,53 @@ describe('<webview> tag', function () {
}) })
}) })
describe('<webview>.goForward()', function () {
it('should work after a replaced history entry', function (done) {
var loadCount = 1
var listener = function (e) {
if (loadCount === 1) {
assert.equal(e.channel, 'history')
assert.equal(e.args[0], 1)
assert(!webview.canGoBack())
assert(!webview.canGoForward())
} else if (loadCount === 2) {
assert.equal(e.channel, 'history')
assert.equal(e.args[0], 2)
assert(!webview.canGoBack())
assert(webview.canGoForward())
webview.removeEventListener('ipc-message', listener)
}
}
var loadListener = function (e) {
if (loadCount === 1) {
webview.src = 'file://' + fixtures + '/pages/base-page.html'
} else if (loadCount === 2) {
assert(webview.canGoBack())
assert(!webview.canGoForward())
webview.goBack()
} else if (loadCount === 3) {
webview.goForward()
} else if (loadCount === 4) {
assert(webview.canGoBack())
assert(!webview.canGoForward())
webview.removeEventListener('did-finish-load', loadListener)
done()
}
loadCount++
}
webview.addEventListener('ipc-message', listener)
webview.addEventListener('did-finish-load', loadListener)
webview.setAttribute('nodeintegration', 'on')
webview.src = 'file://' + fixtures + '/pages/history-replace.html'
document.body.appendChild(webview)
})
})
describe('<webview>.clearHistory()', function () { describe('<webview>.clearHistory()', function () {
it('should clear the navigation history', function (done) { it('should clear the navigation history', function (done) {
var listener = function (e) { var listener = function (e) {