Fixing code review issues: making delegate_ a raw pointer.
This commit is contained in:
parent
61278f9ace
commit
6d7f179a9b
4 changed files with 8 additions and 10 deletions
|
@ -158,8 +158,7 @@ bool URLRequest::ResponseState::Failed() const {
|
|||
return IsFlagSet(ResponseStateFlags::kFailed);
|
||||
}
|
||||
|
||||
URLRequest::URLRequest(v8::Isolate* isolate, v8::Local<v8::Object> wrapper)
|
||||
: weak_ptr_factory_(this) {
|
||||
URLRequest::URLRequest(v8::Isolate* isolate, v8::Local<v8::Object> wrapper) {
|
||||
InitWith(isolate, wrapper);
|
||||
}
|
||||
|
||||
|
@ -188,9 +187,8 @@ mate::WrappableBase* URLRequest::New(mate::Arguments* args) {
|
|||
|
||||
auto browser_context = session->browser_context();
|
||||
auto api_url_request = new URLRequest(args->isolate(), args->GetThis());
|
||||
auto weak_ptr = api_url_request->weak_ptr_factory_.GetWeakPtr();
|
||||
auto atom_url_request =
|
||||
AtomURLRequest::Create(browser_context, method, url, weak_ptr);
|
||||
AtomURLRequest::Create(browser_context, method, url, api_url_request);
|
||||
|
||||
api_url_request->atom_request_ = atom_url_request;
|
||||
|
||||
|
|
|
@ -200,7 +200,6 @@ class URLRequest : public mate::EventEmitter<URLRequest> {
|
|||
// Used to implement pin/unpin.
|
||||
v8::Global<v8::Object> wrapper_;
|
||||
scoped_refptr<net::HttpResponseHeaders> response_headers_;
|
||||
base::WeakPtrFactory<URLRequest> weak_ptr_factory_;
|
||||
|
||||
DISALLOW_COPY_AND_ASSIGN(URLRequest);
|
||||
};
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue