diff --git a/atom/browser/api/atom_api_window.cc b/atom/browser/api/atom_api_window.cc index 9ecb445b3d7..33bea26b8d1 100644 --- a/atom/browser/api/atom_api_window.cc +++ b/atom/browser/api/atom_api_window.cc @@ -498,8 +498,8 @@ void Window::BuildPrototype(v8::Isolate* isolate, .SetMethod("setMenuBarVisibility", &Window::SetMenuBarVisibility) .SetMethod("isMenuBarVisible", &Window::IsMenuBarVisible) #if defined(OS_MACOSX) - .SetMethod( - "showDefinitionForSelection", &Window::ShowDefinitionForSelection) + .SetMethod("showDefinitionForSelection", + &Window::ShowDefinitionForSelection) #endif .SetMethod("_getWebContents", &Window::GetWebContents) .SetMethod("_getDevToolsWebContents", &Window::GetDevToolsWebContents); diff --git a/atom/browser/native_window_mac.mm b/atom/browser/native_window_mac.mm index 5c66f3b4126..c57ceee97fb 100644 --- a/atom/browser/native_window_mac.mm +++ b/atom/browser/native_window_mac.mm @@ -644,6 +644,8 @@ void NativeWindowMac::SetProgressBar(double progress) { void NativeWindowMac::ShowDefinitionForSelection() { content::WebContents* web_contents = GetWebContents(); + if (!web_contents) + return; content::RenderWidgetHostView* rwhv = web_contents->GetRenderWidgetHostView(); if (!rwhv) return; diff --git a/docs/api/browser-window.md b/docs/api/browser-window.md index 2275756571b..137e8e5b92e 100644 --- a/docs/api/browser-window.md +++ b/docs/api/browser-window.md @@ -426,23 +426,31 @@ Returns whether the window is in kiosk mode. * `filename` String -__OS X Only:__ Sets the pathname of the file the window represents, and the icon -of the file will show in window's title bar. +Sets the pathname of the file the window represents, and the icon of the file +will show in window's title bar. + +__Note__: This API is available only on Mac OS X. ### BrowserWindow.getRepresentedFilename() -__OS X Only:__ Returns the pathname of the file the window represents. +Returns the pathname of the file the window represents. + +__Note__: This API is available only on Mac OS X. ### BrowserWindow.setDocumentEdited(edited) * `edited` Boolean -__OS X Only:__ Specifies whether the window’s document has been edited, and the -icon in titlebar will become grey when set to `true`. +Specifies whether the window’s document has been edited, and the icon in title +bar will become grey when set to `true`. + +__Note__: This API is available only on Mac OS X. ### BrowserWindow.IsDocumentEdited() -__OS X Only:__ Whether the window's document has been edited. +Whether the window's document has been edited. + +__Note__: This API is available only on Mac OS X. ### BrowserWindow.openDevTools() @@ -532,8 +540,9 @@ it will assume `app.getName().desktop`. ### BrowserWindow.showDefinitionForSelection() -Show pop-up dictionary that searches the selected word on the page. -This API is available only on Mac OS. +Shows pop-up dictionary that searches the selected word on the page. + +__Note__: This API is available only on Mac OS X. ### BrowserWindow.setAutoHideMenuBar(hide)