mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

[chromium-style] destructors of ref-counted objects should be private

Browse source
This commit is contained in:
Jeremy Apthorp 2018-04-17 16:23:40 -07:00
parent e6695cf2ec
commit 6c26bb1cf8
5 changed files with 8 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
atom/app/uv_task_runner.h
View file

@ -18,7 +18,6 @@ namespace atom {
class UvTaskRunner : public base::SingleThreadTaskRunner { class UvTaskRunner : public base::SingleThreadTaskRunner {
public: public:
explicit UvTaskRunner(uv_loop_t* loop); explicit UvTaskRunner(uv_loop_t* loop);
~UvTaskRunner() override;
// base::SingleThreadTaskRunner: // base::SingleThreadTaskRunner:
bool PostDelayedTask(const base::Location& from_here, bool PostDelayedTask(const base::Location& from_here,
@ -30,6 +29,7 @@ class UvTaskRunner : public base::SingleThreadTaskRunner {
base::TimeDelta delay) override; base::TimeDelta delay) override;
private: private:
~UvTaskRunner() override;
static void OnTimeout(uv_timer_t* timer); static void OnTimeout(uv_timer_t* timer);
static void OnClose(uv_handle_t* handle); static void OnClose(uv_handle_t* handle);

2
atom/browser/atom_access_token_store.h
View file

@ -12,7 +12,6 @@ namespace atom {
class AtomAccessTokenStore : public device::AccessTokenStore { class AtomAccessTokenStore : public device::AccessTokenStore {
public: public:
AtomAccessTokenStore() = default; AtomAccessTokenStore() = default;
~AtomAccessTokenStore() = default;
// device::AccessTokenStore: // device::AccessTokenStore:
void LoadAccessTokens(const LoadAccessTokensCallback& callback) override {} void LoadAccessTokens(const LoadAccessTokensCallback& callback) override {}
@ -20,6 +19,7 @@ class AtomAccessTokenStore : public device::AccessTokenStore {
const base::string16& access_token) override {} const base::string16& access_token) override {}
private: private:
~AtomAccessTokenStore() override = default;
DISALLOW_COPY_AND_ASSIGN(AtomAccessTokenStore); DISALLOW_COPY_AND_ASSIGN(AtomAccessTokenStore);
}; };

3
atom/browser/atom_quota_permission_context.h
View file

@ -14,7 +14,6 @@ class AtomQuotaPermissionContext : public content::QuotaPermissionContext {
typedef content::QuotaPermissionContext::QuotaPermissionResponse response; typedef content::QuotaPermissionContext::QuotaPermissionResponse response;
AtomQuotaPermissionContext(); AtomQuotaPermissionContext();
virtual ~AtomQuotaPermissionContext();
// content::QuotaPermissionContext: // content::QuotaPermissionContext:
void RequestQuotaPermission(const content::StorageQuotaParams& params, void RequestQuotaPermission(const content::StorageQuotaParams& params,
@ -22,6 +21,8 @@ class AtomQuotaPermissionContext : public content::QuotaPermissionContext {
const PermissionCallback& callback) override; const PermissionCallback& callback) override;
private: private:
~AtomQuotaPermissionContext() override;
DISALLOW_COPY_AND_ASSIGN(AtomQuotaPermissionContext); DISALLOW_COPY_AND_ASSIGN(AtomQuotaPermissionContext);
}; };

3
atom/browser/bridge_task_runner.h
View file

@ -19,7 +19,6 @@ namespace atom {
class BridgeTaskRunner : public base::SingleThreadTaskRunner { class BridgeTaskRunner : public base::SingleThreadTaskRunner {
public: public:
BridgeTaskRunner() {} BridgeTaskRunner() {}
~BridgeTaskRunner() override {}
// Called when message loop is ready. // Called when message loop is ready.
void MessageLoopIsReady(); void MessageLoopIsReady();
@ -36,6 +35,8 @@ class BridgeTaskRunner : public base::SingleThreadTaskRunner {
private: private:
using TaskPair = using TaskPair =
std::tuple<base::Location, base::OnceClosure, base::TimeDelta>; std::tuple<base::Location, base::OnceClosure, base::TimeDelta>;
~BridgeTaskRunner() override {}
std::vector<TaskPair> tasks_; std::vector<TaskPair> tasks_;
std::vector<TaskPair> non_nestable_tasks_; std::vector<TaskPair> non_nestable_tasks_;

3
brightray/browser/url_request_context_getter.h
View file

@ -73,7 +73,6 @@ class URLRequestContextGetter : public net::URLRequestContextGetter {
scoped_refptr<base::SingleThreadTaskRunner> io_task_runner, scoped_refptr<base::SingleThreadTaskRunner> io_task_runner,
content::ProtocolHandlerMap* protocol_handlers, content::ProtocolHandlerMap* protocol_handlers,
content::URLRequestInterceptorScopedVector protocol_interceptors); content::URLRequestInterceptorScopedVector protocol_interceptors);
~URLRequestContextGetter() override;
// net::CookieStore::CookieChangedCallback implementation. // net::CookieStore::CookieChangedCallback implementation.
void OnCookieChanged(const net::CanonicalCookie& cookie, void OnCookieChanged(const net::CanonicalCookie& cookie,
@ -90,6 +89,8 @@ class URLRequestContextGetter : public net::URLRequestContextGetter {
void NotifyContextShutdownOnIO(); void NotifyContextShutdownOnIO();
private: private:
~URLRequestContextGetter() override;
Delegate* delegate_; Delegate* delegate_;
NetLog* net_log_; NetLog* net_log_;