mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

refactor: replace base::StringPrintf() calls with absl::StrFormat() (#46049)

Browse source 
The former is now a pass-through for the latter and is slated for removal

Xref: https://issues.chromium.org/issues/40241565

4907781

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
This commit is contained in:
trop[bot] 2025-03-15 11:23:10 -05:00 • committed by GitHub
parent 3ad43182eb
commit 6bbe996f62
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 17 additions and 18 deletions
Download patch file Download diff file Expand all files Collapse all files

15
shell/browser/api/electron_api_session.cc
View file

@ -1079,9 +1079,9 @@ std::string Session::RegisterPreloadScript(
});
if (it != preload_scripts.end()) {
thrower.ThrowError(base::StringPrintf(
"Cannot register preload script with existing ID '%s'",
new_preload_script.id.c_str()));
thrower.ThrowError(
absl::StrFormat("Cannot register preload script with existing ID '%s'",
new_preload_script.id));
return "";
}
@ -1092,8 +1092,8 @@ std::string Session::RegisterPreloadScript(
<< new_preload_script.file_path;
} else {
thrower.ThrowError(
base::StringPrintf("Preload script must have absolute path: %s",
new_preload_script.file_path.value().c_str()));
absl::StrFormat("Preload script must have absolute path: %s",
new_preload_script.file_path.value()));
return "";
}
}
@ -1122,9 +1122,8 @@ void Session::UnregisterPreloadScript(gin_helper::ErrorThrower thrower,
}
// If the script is not found, throw an error
thrower.ThrowError(base::StringPrintf(
"Cannot unregister preload script with non-existing ID '%s'",
script_id.c_str()));
thrower.ThrowError(absl::StrFormat(
"Cannot unregister preload script with non-existing ID '%s'", script_id));
}
std::vector<PreloadScript> Session::GetPreloadScripts() const {