From b307b6e602890e00f9e0dae2db8b5b1c7e966778 Mon Sep 17 00:00:00 2001 From: Kevin Sawicki Date: Thu, 25 May 2017 17:30:30 -0700 Subject: [PATCH] Remove runas and code no longer using it --- package.json | 3 --- script/dump-symbols.py | 9 --------- tools/win/register_msdia80_dll.js | 12 ------------ 3 files changed, 24 deletions(-) delete mode 100644 tools/win/register_msdia80_dll.js diff --git a/package.json b/package.json index 18bd13c062d2..a1f3b8608c62 100644 --- a/package.json +++ b/package.json @@ -11,9 +11,6 @@ "standard": "^8.4.0", "standard-markdown": "^2.1.1" }, - "optionalDependencies": { - "runas": "^3.0.0" - }, "standard": { "ignore": [ "/out", diff --git a/script/dump-symbols.py b/script/dump-symbols.py index fdc90b613f66..96cb2c10d634 100755 --- a/script/dump-symbols.py +++ b/script/dump-symbols.py @@ -15,9 +15,6 @@ CHROMIUM_DIR = os.path.join(SOURCE_ROOT, 'vendor', 'download', def main(destination): - # if PLATFORM == 'win32': - # register_required_dll() - rm_rf(destination) (project_name, product_name) = get_names_from_gyp() @@ -49,12 +46,6 @@ def main(destination): execute([sys.executable, generate_breakpad_symbols] + args) -def register_required_dll(): - register = os.path.join(SOURCE_ROOT, 'tools', 'win', - 'register_msdia80_dll.js') - execute(['node.exe', os.path.relpath(register)]); - - def get_names_from_gyp(): variables = electron_gyp() return (variables['project_name%'], variables['product_name%']) diff --git a/tools/win/register_msdia80_dll.js b/tools/win/register_msdia80_dll.js deleted file mode 100644 index e90b9714d1f1..000000000000 --- a/tools/win/register_msdia80_dll.js +++ /dev/null @@ -1,12 +0,0 @@ -var fs = require('fs') -var path = require('path') -var runas = require('runas') - -var source = path.resolve(__dirname, '..', '..', 'vendor', 'breakpad', 'msdia80.dll') -var target = 'C:\\Program Files\\Common Files\\Microsoft Shared\\VC\\msdia80.dll' - -if (!fs.existsSync(target)) { - runas('cmd', - ['/K', 'copy', source, target, '&', 'regsvr32', '/s', target, '&', 'exit'], - {admin: true}) -}