mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

Fix leaking WebContents from devtools.

Browse source
This commit is contained in:
Cheng Zhao 2014-10-27 16:42:54 +08:00
parent 7b39673215
commit 6b49e23312
2 changed files with 19 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

11
brightray/browser/inspectable_web_contents_impl.cc
View file

@ -355,6 +355,17 @@ bool InspectableWebContentsImpl::AddMessageToConsole(
return true; return true;
} }
bool InspectableWebContentsImpl::ShouldCreateWebContents(
content::WebContents* web_contents,
int route_id,
WindowContainerType window_container_type,
const base::string16& frame_name,
const GURL& target_url,
const std::string& partition_id,
content::SessionStorageNamespace* session_storage_namespace) {
return false;
}
void InspectableWebContentsImpl::HandleKeyboardEvent( void InspectableWebContentsImpl::HandleKeyboardEvent(
content::WebContents* source, content::WebContents* source,
const content::NativeWebKeyboardEvent& event) { const content::NativeWebKeyboardEvent& event) {

8
brightray/browser/inspectable_web_contents_impl.h
View file

@ -113,6 +113,14 @@ class InspectableWebContentsImpl :
const base::string16& message, const base::string16& message,
int32 line_no, int32 line_no,
const base::string16& source_id) override; const base::string16& source_id) override;
bool ShouldCreateWebContents(
content::WebContents* web_contents,
int route_id,
WindowContainerType window_container_type,
const base::string16& frame_name,
const GURL& target_url,
const std::string& partition_id,
content::SessionStorageNamespace* session_storage_namespace) override;
void HandleKeyboardEvent( void HandleKeyboardEvent(
content::WebContents*, const content::NativeWebKeyboardEvent&) override; content::WebContents*, const content::NativeWebKeyboardEvent&) override;
void CloseContents(content::WebContents* source) override; void CloseContents(content::WebContents* source) override;