From 6b2ddc481477f6311cd3d8994c2421a2d1540823 Mon Sep 17 00:00:00 2001 From: Thiago de Arruda Date: Fri, 3 Nov 2017 14:48:37 -0300 Subject: [PATCH] Stop allowing `electron.net` requests to be intercepted. Not very useful to intercept requests from `electron.net`, since both the interception machinery and `electron.net` live in the browser process. --- atom/browser/api/atom_api_protocol.h | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/atom/browser/api/atom_api_protocol.h b/atom/browser/api/atom_api_protocol.h index dfc32be6bc57..40dc30600f93 100644 --- a/atom/browser/api/atom_api_protocol.h +++ b/atom/browser/api/atom_api_protocol.h @@ -78,6 +78,10 @@ class Protocol : public mate::TrackableObject { net::URLRequestJob* MaybeCreateJob( net::URLRequest* request, net::NetworkDelegate* network_delegate) const override { + if (!request->initiator().has_value()) { + // Don't intercept this request as it was created by `net.request`. + return nullptr; + } RequestJob* request_job = new RequestJob(request, network_delegate); request_job->SetHandlerInfo(isolate_, request_context_.get(), handler_); return request_job;