Merge pull request #6810 from electron/iframe-ismainpage-event

Send isMainFrame as argument to did-navigate-in-page event
This commit is contained in:
Cheng Zhao 2016-08-12 17:10:47 +09:00 committed by GitHub
commit 6a7c6cae3a
4 changed files with 4 additions and 2 deletions

View file

@ -674,7 +674,7 @@ void WebContents::DidFinishNavigation(
if (is_main_frame && !is_in_page) {
Emit("did-navigate", url);
} else if (is_in_page) {
Emit("did-navigate-in-page", url);
Emit("did-navigate-in-page", url, is_main_frame);
}
} else {
auto url = navigation_handle->GetURL();

View file

@ -185,6 +185,7 @@ Returns:
* `event` Event
* `url` String
* `isMainFrame` Boolean
Emitted when an in-page navigation happened.

View file

@ -710,6 +710,7 @@ this purpose.
Returns:
* `isMainFrame` Boolean
* `url` String
Emitted when an in-page navigation happened.

View file

@ -22,7 +22,7 @@ var WEB_VIEW_EVENTS = {
'new-window': ['url', 'frameName', 'disposition', 'options'],
'will-navigate': ['url'],
'did-navigate': ['url'],
'did-navigate-in-page': ['url'],
'did-navigate-in-page': ['url', 'isMainFrame'],
'close': [],
'crashed': [],
'gpu-crashed': [],