mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

fix: expose native bindings by process type (#35949)

Browse source
This commit is contained in:
Milan Burda 2023-02-08 02:22:18 +01:00 • committed by GitHub
parent de607cbcde
commit 6a3cb34326
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 85 additions and 21 deletions
Download patch file Download diff file Expand all files Collapse all files

43
spec/internal-spec.ts
View file

@ -1,4 +1,6 @@
import { expect } from 'chai';
import { BrowserWindow } from 'electron/main';
import { closeAllWindows } from './lib/window-helpers';
describe('feature-string parsing', () => {
it('is indifferent to whitespace around keys and values', () => {
@ -19,3 +21,44 @@ describe('feature-string parsing', () => {
checkParse(' a = yes , c = d ', { a: true, c: 'd' });
});
});
describe('process._linkedBinding', () => {
describe('in the main process', () => {
it('can access electron_browser bindings', () => {
process._linkedBinding('electron_browser_app');
});
it('can access electron_common bindings', () => {
process._linkedBinding('electron_common_v8_util');
});
it('cannot access electron_renderer bindings', () => {
expect(() => {
process._linkedBinding('electron_renderer_ipc');
}).to.throw(/No such binding was linked: electron_renderer_ipc/);
});
});
describe('in the renderer process', () => {
afterEach(closeAllWindows);
it('cannot access electron_browser bindings', async () => {
const w = new BrowserWindow({ show: false, webPreferences: { nodeIntegration: true, contextIsolation: false } });
w.loadURL('about:blank');
await expect(w.webContents.executeJavaScript('void process._linkedBinding(\'electron_browser_app\')'))
.to.eventually.be.rejectedWith(/Script failed to execute/);
});
it('can access electron_common bindings', async () => {
const w = new BrowserWindow({ show: false, webPreferences: { nodeIntegration: true, contextIsolation: false } });
w.loadURL('about:blank');
await w.webContents.executeJavaScript('void process._linkedBinding(\'electron_common_v8_util\')');
});
it('can access electron_renderer bindings', async () => {
const w = new BrowserWindow({ show: false, webPreferences: { nodeIntegration: true, contextIsolation: false } });
w.loadURL('about:blank');
await w.webContents.executeJavaScript('void process._linkedBinding(\'electron_renderer_ipc\')');
});
});
});