mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

refactor: make util::Promise type safe when chaining in native (#19809)

Browse source 
* refactor: make util::Promise type safe when chaining in native

* fixup! refactor: make util::Promise type safe when chaining in native

* chore: remove spare brackets
This commit is contained in:
Samuel Attard 2019-08-22 17:03:28 -07:00 • committed by GitHub
parent f7e3e1f97a
commit 6a3922d330
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
39 changed files with 275 additions and 343 deletions
Download patch file Download diff file Expand all files Collapse all files

4
shell/browser/browser.h
View file

@ -262,7 +262,7 @@ class Browser : public WindowListObserver {
bool is_shutting_down() const { return is_shutdown_; }
bool is_quiting() const { return is_quiting_; }
bool is_ready() const { return is_ready_; }
const util::Promise& WhenReady(v8::Isolate* isolate);
const util::Promise<void*>& WhenReady(v8::Isolate* isolate);
protected:
// Returns the version of application bundle or executable file.
@ -301,7 +301,7 @@ class Browser : public WindowListObserver {
int badge_count_ = 0;
std::unique_ptr<util::Promise> ready_promise_;
std::unique_ptr<util::Promise<void*>> ready_promise_;
#if defined(OS_LINUX) || defined(OS_WIN)
base::Value about_panel_options_;