mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

refactor: make util::Promise type safe when chaining in native (#19809)

Browse source 
* refactor: make util::Promise type safe when chaining in native

* fixup! refactor: make util::Promise type safe when chaining in native

* chore: remove spare brackets
This commit is contained in:
Samuel Attard 2019-08-22 17:03:28 -07:00 • committed by GitHub
parent f7e3e1f97a
commit 6a3922d330
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
39 changed files with 275 additions and 343 deletions
Download patch file Download diff file Expand all files Collapse all files

4
shell/browser/browser.cc
View file

@ -165,9 +165,9 @@ void Browser::DidFinishLaunching(const base::DictionaryValue& launch_info) {
observer.OnFinishLaunching(launch_info);
}
const util::Promise& Browser::WhenReady(v8::Isolate* isolate) {
const util::Promise<void*>& Browser::WhenReady(v8::Isolate* isolate) {
if (!ready_promise_) {
ready_promise_.reset(new util::Promise(isolate));
ready_promise_.reset(new util::Promise<void*>(isolate));
if (is_ready()) {
ready_promise_->Resolve();
}