From 69eb076bca6de06df258421b654d78b35c9c6a23 Mon Sep 17 00:00:00 2001 From: Charles Kerr Date: Mon, 24 Feb 2025 10:09:01 -0600 Subject: [PATCH] refactor: do not use `AdaptCallbackForRepeating()` in `electron_api_url_loader.cc` (#45771) refactor: do not use AdaptCallbackForRepeating in electron_api_url_loader.cc --- shell/common/api/electron_api_url_loader.cc | 5 ++--- shell/common/gin_helper/event_emitter_caller.h | 1 + 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/shell/common/api/electron_api_url_loader.cc b/shell/common/api/electron_api_url_loader.cc index 612843565f8a..607e6bee734d 100644 --- a/shell/common/api/electron_api_url_loader.cc +++ b/shell/common/api/electron_api_url_loader.cc @@ -438,7 +438,7 @@ void SimpleURLLoaderWrapper::OnAuthRequired( net::AuthCredentials(username_str, password_str)); }, std::move(auth_responder)); - Emit("login", auth_info, base::AdaptCallbackForRepeating(std::move(cb))); + Emit("login", auth_info, std::move(cb)); } void SimpleURLLoaderWrapper::OnSSLCertificateError( @@ -716,8 +716,7 @@ void SimpleURLLoaderWrapper::OnDataReceived(std::string_view string_view, v8::HandleScope handle_scope(isolate); auto array_buffer = v8::ArrayBuffer::New(isolate, string_view.size()); memcpy(array_buffer->Data(), string_view.data(), string_view.size()); - Emit("data", array_buffer, - base::AdaptCallbackForRepeating(std::move(resume))); + Emit("data", array_buffer, std::move(resume)); } void SimpleURLLoaderWrapper::OnComplete(bool success) { diff --git a/shell/common/gin_helper/event_emitter_caller.h b/shell/common/gin_helper/event_emitter_caller.h index 3859f0235975..0ac374f84079 100644 --- a/shell/common/gin_helper/event_emitter_caller.h +++ b/shell/common/gin_helper/event_emitter_caller.h @@ -11,6 +11,7 @@ #include "base/containers/span.h" #include "gin/converter.h" #include "gin/wrappable.h" +#include "shell/common/gin_converters/std_converter.h" // for ConvertToV8(iso, &&) namespace gin_helper {