mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

providing option to undock devtools from browser-window

Browse source
This commit is contained in:
deepak1556 2015-03-26 14:43:35 +05:30
parent ae5586408f
commit 69d958b94e
7 changed files with 16 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

4
atom/browser/api/atom_api_window.cc
View file

@ -322,8 +322,8 @@ bool Window::IsKiosk() {
return window_->IsKiosk();
}
void Window::OpenDevTools() {
window_->OpenDevTools();
void Window::OpenDevTools(bool dock) {
window_->OpenDevTools(!dock);
}
void Window::CloseDevTools() {

2
atom/browser/api/atom_api_window.h
View file

@ -105,7 +105,7 @@ class Window : public mate::EventEmitter,
void SetSkipTaskbar(bool skip);
void SetKiosk(bool kiosk);
bool IsKiosk();
void OpenDevTools();
void OpenDevTools(bool dock);
void CloseDevTools();
bool IsDevToolsOpened();
void InspectElement(int x, int y);

5
atom/browser/api/lib/browser-window.coffee
View file

@ -40,8 +40,9 @@ BrowserWindow::_init = ->
@once 'closed', =>
BrowserWindow.windows.remove @id if BrowserWindow.windows.has @id
BrowserWindow::openDevTools = ->
@_openDevTools()
BrowserWindow::openDevTools = (options={}) ->
options.detach ?= false
@_openDevTools(options.detach)
# Force devToolsWebContents to be created.
@devToolsWebContents = @getDevToolsWebContents()