mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

fix: reparenting after BrowserWindow.destroy() (#39062)

Browse source 
fix: reparenting after BrowserWindow.destroy()
This commit is contained in:
Shelley Vohr 2023-07-26 16:47:32 +02:00 • committed by GitHub
parent fa5b1be6f3
commit 695fcf3cb2
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 46 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

21
spec/api-browser-window-spec.ts
View file

@ -4797,6 +4797,7 @@ describe('BrowserWindow module', () => {
c.setParentWindow(null);
expect(c.getParentWindow()).to.be.null('c.parent');
});
it('adds window to child windows of parent', () => {
const w = new BrowserWindow({ show: false });
const c = new BrowserWindow({ show: false });
@ -4806,6 +4807,7 @@ describe('BrowserWindow module', () => {
c.setParentWindow(null);
expect(w.getChildWindows()).to.deep.equal([]);
});
it('removes from child windows of parent when window is closed', async () => {
const w = new BrowserWindow({ show: false });
const c = new BrowserWindow({ show: false });
@ -4817,6 +4819,25 @@ describe('BrowserWindow module', () => {
await setTimeout();
expect(w.getChildWindows().length).to.equal(0);
});
ifit(process.platform === 'darwin')('can reparent when the first parent is destroyed', async () => {
const w1 = new BrowserWindow({ show: false });
const w2 = new BrowserWindow({ show: false });
const c = new BrowserWindow({ show: false });
c.setParentWindow(w1);
expect(w1.getChildWindows().length).to.equal(1);
const closed = once(w1, 'closed');
w1.destroy();
await closed;
c.setParentWindow(w2);
await setTimeout();
const children = w2.getChildWindows();
expect(children[0]).to.equal(c);
});
});
describe('modal option', () => {