mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

Remove base::ListValue::Set(size_t, base::Value*)

Browse source 
https://codereview.chromium.org/2838893002
This commit is contained in:
Aleksei Kuzmin 2017-08-12 20:39:29 +03:00 • committed by Cheng Zhao
parent 2c063f93ff
commit 68cbfd9f40
1 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
chromium_src/chrome/browser/printing/print_job_worker.cc
View file

@ -99,8 +99,8 @@ void PrintSettingsToJobSettings(const PrintSettings& settings,
// range // range
if (!settings.ranges().empty()) { if (!settings.ranges().empty()) {
base::ListValue* page_range_array = new base::ListValue; auto page_range_array = base::MakeUnique<base::ListValue>();
job_settings->Set(kSettingPageRange, page_range_array); job_settings->Set(kSettingPageRange, std::move(page_range_array));
for (size_t i = 0; i < settings.ranges().size(); ++i) { for (size_t i = 0; i < settings.ranges().size(); ++i) {
std::unique_ptr<base::DictionaryValue> dict(new base::DictionaryValue); std::unique_ptr<base::DictionaryValue> dict(new base::DictionaryValue);
dict->SetInteger(kSettingPageRangeFrom, settings.ranges()[i].from + 1); dict->SetInteger(kSettingPageRangeFrom, settings.ranges()[i].from + 1);