mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

Merge pull request #1215 from deepak1556/dialog_patch

Browse source 
avoid overriding type value of showMessageBox
This commit is contained in:
Cheng Zhao 2015-03-09 13:50:18 -07:00
commit 6856d203c5
2 changed files with 4 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
.gitignore vendored
View file

@ -10,3 +10,4 @@ node_modules/
*.xcodeproj
*.swp
*.pyc
npm-debug.log

6
atom/browser/api/lib/dialog.coffee
View file

@ -83,8 +83,8 @@ module.exports =
options ?= type: 'none'
options.type ?= 'none'
options.type = messageBoxTypes.indexOf options.type
throw new TypeError('Invalid message box type') unless options.type > -1
messageBoxType = messageBoxTypes.indexOf options.type
throw new TypeError('Invalid message box type') unless messageBoxType > -1
throw new TypeError('Buttons need to be array') unless Array.isArray options.buttons
@ -93,7 +93,7 @@ module.exports =
options.detail ?= ''
options.icon ?= null
binding.showMessageBox options.type,
binding.showMessageBox messageBoxType,
options.buttons,
[options.title, options.message, options.detail],
options.icon,