mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

Review CommentZ

Browse source
This commit is contained in:
Charlie Hess 2017-01-11 15:32:43 -08:00 • committed by Kevin Sawicki
parent 41ea169784
commit 67f7a60524
1 changed files with 3 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

6
lib/browser/rpc-server.js
View file

@ -146,11 +146,11 @@ const throwRPCError = function (message) {
throw error throw error
} }
const rendererMissingErrorMessage = function (meta, args, callIntoRenderer) { const rendererMissingErrorMessage = (meta, args, callIntoRenderer) => {
let message = `Attempting to call a function in a renderer window that has been closed or released.` + let message = `Attempting to call a function in a renderer window that has been closed or released.` +
`\nFunction provided here: ${meta.location}` `\nFunction provided here: ${meta.location}`
if (!args || args.length === 0) return message if (args.length === 0) return message
if (!args[0].sender || !args[0].sender._events) return message if (!args[0].sender || !args[0].sender._events) return message
const eventsAttached = args[0].sender._events const eventsAttached = args[0].sender._events
@ -160,7 +160,7 @@ const rendererMissingErrorMessage = function (meta, args, callIntoRenderer) {
: eventsAttached[eventName] === callIntoRenderer : eventsAttached[eventName] === callIntoRenderer
}) })
if (remoteEvents && remoteEvents.length > 0) { if (remoteEvents.length > 0) {
message += `\nRemote event names:` message += `\nRemote event names:`
remoteEvents.forEach((eventName) => { remoteEvents.forEach((eventName) => {
message += ` ${eventName} ` message += ` ${eventName} `