fix: performance-no-automatic-move
clang-tidy warnings (#44742)
* fix: performance-no-automatic-move in GetLogFileName() remove `const` from log_filename. Warning fixed by this commit: ../../electron/shell/common/logging.cc:40:12: warning: constness of 'log_filename' prevents automatic move [performance-no-automatic-move] * fix: performance-no-automatic-move in GetBundleResourcePath() remove `const` from request_relative_path. Warning fixed by this commit: electron/shell/browser/extensions/electron_extensions_browser_client.cc:187:10: warning: constness of 'request_relative_path' prevents automatic move [performance-no-automatic-move]
This commit is contained in:
parent
0ea64850af
commit
6789431f74
2 changed files with 7 additions and 10 deletions
|
@ -174,7 +174,7 @@ base::FilePath ElectronExtensionsBrowserClient::GetBundleResourcePath(
|
||||||
if (!chrome_resources_path.IsParent(extension_resources_path))
|
if (!chrome_resources_path.IsParent(extension_resources_path))
|
||||||
return base::FilePath();
|
return base::FilePath();
|
||||||
|
|
||||||
const base::FilePath request_relative_path =
|
base::FilePath request_relative_path =
|
||||||
extensions::file_util::ExtensionURLToRelativeFilePath(request.url);
|
extensions::file_util::ExtensionURLToRelativeFilePath(request.url);
|
||||||
if (!ExtensionsBrowserClient::Get()
|
if (!ExtensionsBrowserClient::Get()
|
||||||
->GetComponentExtensionResourceManager()
|
->GetComponentExtensionResourceManager()
|
||||||
|
|
|
@ -29,16 +29,13 @@ base::FilePath GetLogFileName(const base::CommandLine& command_line) {
|
||||||
if (!filename.empty())
|
if (!filename.empty())
|
||||||
return base::FilePath::FromUTF8Unsafe(filename);
|
return base::FilePath::FromUTF8Unsafe(filename);
|
||||||
|
|
||||||
const base::FilePath log_filename(FILE_PATH_LITERAL("electron_debug.log"));
|
auto log_filename = base::FilePath{FILE_PATH_LITERAL("electron_debug.log")};
|
||||||
base::FilePath log_path;
|
|
||||||
|
|
||||||
if (base::PathService::Get(chrome::DIR_LOGS, &log_path)) {
|
if (base::FilePath path; base::PathService::Get(chrome::DIR_LOGS, &path))
|
||||||
log_path = log_path.Append(log_filename);
|
return path.Append(log_filename);
|
||||||
return log_path;
|
|
||||||
} else {
|
// error with path service, just use some default file somewhere
|
||||||
// error with path service, just use some default file somewhere
|
return log_filename;
|
||||||
return log_filename;
|
|
||||||
}
|
|
||||||
}
|
}
|
||||||
|
|
||||||
namespace {
|
namespace {
|
||||||
|
|
Loading…
Add table
Reference in a new issue