mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

chore: remove unused deprecate.fnToProperty() (#24069)

Browse source
This commit is contained in:
Milan Burda 2020-06-16 03:59:04 +02:00 • committed by GitHub
parent 9c7d73c6d6
commit 673169a7ba
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 0 additions and 42 deletions
Download patch file Download diff file Expand all files Collapse all files

24
spec-main/api-deprecate-spec.ts
View file

@ -169,30 +169,6 @@ describe('deprecate', () => {
}).to.throw(/this is deprecated/);
});
it('warns when a function is deprecated in favor of a property', () => {
const warnings: string[] = [];
deprecate.setHandler(warning => warnings.push(warning));
const newProp = 'newProp';
const mod: any = {
_oldGetterFn () { return 'getter'; },
_oldSetterFn () { return 'setter'; }
};
deprecate.fnToProperty(mod, 'newProp', '_oldGetterFn', '_oldSetterFn');
mod.oldGetterFn();
mod.oldSetterFn();
expect(warnings).to.have.lengthOf(2);
expect(warnings[0]).to.include('oldGetterFn');
expect(warnings[0]).to.include(newProp);
expect(warnings[1]).to.include('oldSetterFn');
expect(warnings[1]).to.include(newProp);
});
describe('moveAPI', () => {
beforeEach(() => {
deprecate.setHandler(null);