mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

💄 Cache last argument in parseArgs

Browse source 
This is to eliminate the need to access the array twice.
This commit is contained in:
Steve Kinney 2016-05-07 08:52:52 -06:00
commit 6708e2a302
1 changed files with 3 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

5
lib/browser/api/dialog.js
View file

@ -35,8 +35,9 @@ var parseArgs = function (window, options, callback, ...args) {
} }
// Fallback to using very last argument as the callback function // Fallback to using very last argument as the callback function
if ((callback == null) && typeof args[args.length - 1] === 'function') { var lastArgument = args[args.length - 1]
callback = args[args.length - 1] if ((callback == null) && typeof lastArgument === 'function') {
callback = lastArgument
} }
return [window, options, callback] return [window, options, callback]