mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

sec: deprecate some webPreference defaults to be secure-by-default (#14284)

Browse source 
* feat: deprecate default value of nodeIntegration

* Use DeprecationStatus::Stable as the default instead of shadowing

* change wording of deprecations

* chore: also deprecate kWebviewTag and kContextIsolation

* chore: do as we preach, lets be secure-by-default in the default app
This commit is contained in:
Samuel Attard 2018-08-30 06:14:04 +12:00 • committed by Charles Kerr
parent 9b2c14a745
commit 66d6ba8689
9 changed files with 100 additions and 43 deletions
Download patch file Download diff file Expand all files Collapse all files

6
lib/common/api/deprecate.js
View file

@ -31,6 +31,12 @@ deprecate.warn = (oldName, newName) => {
return deprecate.log(`'${oldName}' is deprecated. Use '${newName}' instead.`)
}
deprecate.warnDefault = (propName, oldDefault, newDefault) => {
return deprecate.log(`The default value of '${propName}' is changing from \
'${oldDefault}' to '${newDefault}' in a future release. If you want to keep \
the current value, please explicitly declare the property.`)
}
let deprecationHandler = null
// Print deprecation message.