mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

sec: deprecate some webPreference defaults to be secure-by-default (#14284)

Browse source 
* feat: deprecate default value of nodeIntegration

* Use DeprecationStatus::Stable as the default instead of shadowing

* change wording of deprecations

* chore: also deprecate kWebviewTag and kContextIsolation

* chore: do as we preach, lets be secure-by-default in the default app
This commit is contained in:
Samuel Attard 2018-08-30 06:14:04 +12:00 • committed by Charles Kerr
parent 9b2c14a745
commit 66d6ba8689
9 changed files with 100 additions and 43 deletions
Download patch file Download diff file Expand all files Collapse all files

12
docs/api/breaking-changes.md
View file

@ -34,6 +34,18 @@ app.releaseSingleInstance()
app.releaseSingleInstanceLock()
```
## `new BrowserWindow({ webPreferences: { ... }})`
```js
// Deprecated defaults
const webPreferences = {}
new BrowserWindow({ webPreferences })
// webPreferences.contextIsolation - Default was false, will be true
// webPreferences.nodeIntegration - Default was true, will be false
// webPreferences.webviewTag - Default was true, will be false
```
# Breaking API Changes (3.0)