mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

sec: deprecate some webPreference defaults to be secure-by-default (#14284)

Browse source 
* feat: deprecate default value of nodeIntegration

* Use DeprecationStatus::Stable as the default instead of shadowing

* change wording of deprecations

* chore: also deprecate kWebviewTag and kContextIsolation

* chore: do as we preach, lets be secure-by-default in the default app
This commit is contained in:
Samuel Attard 2018-08-30 06:14:04 +12:00 • committed by Charles Kerr
parent 9b2c14a745
commit 66d6ba8689
9 changed files with 100 additions and 43 deletions
Download patch file Download diff file Expand all files Collapse all files

6
atom/browser/web_contents_preferences.h
View file

@ -66,11 +66,15 @@ class WebContentsPreferences
friend class content::WebContentsUserData<WebContentsPreferences>;
friend class AtomBrowserClient;
enum class Status { Deprecated, Stable };
// Get WebContents according to process ID.
static content::WebContents* GetWebContentsFromProcessID(int process_id);
// Set preference value to given bool if user did not provide value
bool SetDefaultBoolIfUndefined(const base::StringPiece& key, bool val);
bool SetDefaultBoolIfUndefined(const base::StringPiece& key,
bool val,
Status status = Status::Stable);
static std::vector<WebContentsPreferences*> instances_;