From 6667de28e31e3a333240743b1926d5b76f22da6d Mon Sep 17 00:00:00 2001 From: Milan Burda Date: Tue, 24 May 2022 10:23:56 +0200 Subject: [PATCH] chore: use webContents.setWindowOpenHandler() in default-app (#34308) --- default_app/default_app.ts | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/default_app/default_app.ts b/default_app/default_app.ts index 44bc2ebd9aff..0bac02033173 100644 --- a/default_app/default_app.ts +++ b/default_app/default_app.ts @@ -66,9 +66,9 @@ async function createWindow (backgroundColor?: string) { mainWindow = new BrowserWindow(options); mainWindow.on('ready-to-show', () => mainWindow!.show()); - mainWindow.webContents.on('new-window', (event, url) => { - event.preventDefault(); - shell.openExternal(decorateURL(url)); + mainWindow.webContents.setWindowOpenHandler(details => { + shell.openExternal(decorateURL(details.url)); + return { action: 'deny' }; }); mainWindow.webContents.session.setPermissionRequestHandler((webContents, permission, done) => {