mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

docs: windows don't need to be retained (#21957)

Browse source
This commit is contained in:
Jeremy Apthorp 2020-01-30 14:15:35 -08:00 • committed by GitHub
parent 23382e6e08
commit 662b94f46e
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 7 additions and 25 deletions
Download patch file Download diff file Expand all files Collapse all files

16
docs/tutorial/first-app.md
View file

@ -132,13 +132,9 @@ windows on macOS if the user clicks on the app's icon in the dock.
```javascript
const { app, BrowserWindow } = require('electron')
// Keep a global reference of the window object, if you don't, the window will
// be closed automatically when the JavaScript object is garbage collected.
let win
function createWindow () {
// Create the browser window.
win = new BrowserWindow({
const win = new BrowserWindow({
width: 800,
height: 600,
webPreferences: {
@ -151,14 +147,6 @@ function createWindow () {
// Open the DevTools.
win.webContents.openDevTools()
// Emitted when the window is closed.
win.on('closed', () => {
// Dereference the window object, usually you would store windows
// in an array if your app supports multi windows, this is the time
// when you should delete the corresponding element.
win = null
})
}
// This method will be called when Electron has finished
@ -178,7 +166,7 @@ app.on('window-all-closed', () => {
app.on('activate', () => {
// On macOS it's common to re-create a window in the app when the
// dock icon is clicked and there are no other windows open.
if (win === null) {
if (BrowserWindow.getAllWindows().length === 0) {
createWindow()
}
})