mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

fix: don't expose nativeTheme in the renderer process (#20139)

Browse source 
Exposing these in the renderer didn't make sense as they weren't backed
by the same instance / value store.  This API should be browser only
especially now that we have nativeTheme.themeSource.  Exposing in
//common was a mistake from the beginning.
This commit is contained in:
Samuel Attard 2019-09-16 14:23:13 -07:00 • committed by GitHub
parent 999f7df158
commit 660e566201
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
9 changed files with 11 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

2
shell/common/api/atom_api_native_theme.cc → shell/browser/api/atom_api_native_theme.cc
View file

@ -2,7 +2,7 @@
// Use of this source code is governed by the MIT license that can be
// found in the LICENSE file.
#include "shell/common/api/atom_api_native_theme.h"
#include "shell/browser/api/atom_api_native_theme.h"
#include <string>

6
shell/common/api/atom_api_native_theme.h → shell/browser/api/atom_api_native_theme.h
View file

@ -2,8 +2,8 @@
// Use of this source code is governed by the MIT license that can be
// found in the LICENSE file.
#ifndef SHELL_COMMON_API_ATOM_API_NATIVE_THEME_H_
#define SHELL_COMMON_API_ATOM_API_NATIVE_THEME_H_
#ifndef SHELL_BROWSER_API_ATOM_API_NATIVE_THEME_H_
#define SHELL_BROWSER_API_ATOM_API_NATIVE_THEME_H_
#include "native_mate/handle.h"
#include "shell/browser/api/event_emitter.h"
@ -62,4 +62,4 @@ struct Converter<ui::NativeTheme::ThemeSource> {
} // namespace mate
#endif // SHELL_COMMON_API_ATOM_API_NATIVE_THEME_H_
#endif // SHELL_BROWSER_API_ATOM_API_NATIVE_THEME_H_

2
shell/common/api/atom_api_native_theme_mac.mm → shell/browser/api/atom_api_native_theme_mac.mm
View file

@ -2,7 +2,7 @@
// Use of this source code is governed by the MIT license that can be
// found in the LICENSE file.
#include "shell/common/api/atom_api_native_theme.h"
#include "shell/browser/api/atom_api_native_theme.h"
#include "base/mac/sdk_forward_declarations.h"
#include "shell/browser/mac/atom_application.h"