mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

fix: Revert "fix: make sure that menu bar gets focus even when you click an item to focus it first (#19710)" (#20019)

Browse source 
This reverts commit 27b2747b61.
This commit is contained in:
Samuel Attard 2019-08-29 15:06:39 -07:00 committed by GitHub
parent a9e3dabc8a
commit 654338693f
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 0 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
shell/browser/ui/views/menu_bar.cc
View file

@ -270,12 +270,6 @@ void MenuBar::OnMenuButtonClicked(views::Button* source,
if (!window_->HasFocus()) if (!window_->HasFocus())
window_->RequestFocus(); window_->RequestFocus();
// This ensures that if you focus the menubar by clicking on an item, you can
// still use the arrow keys to move around
if (GetPaneFocusTraversable() == nullptr) {
SetPaneFocus(source);
}
int id = source->tag(); int id = source->tag();
AtomMenuModel::ItemType type = menu_model_->GetTypeAt(id); AtomMenuModel::ItemType type = menu_model_->GetTypeAt(id);
if (type != AtomMenuModel::TYPE_SUBMENU) { if (type != AtomMenuModel::TYPE_SUBMENU) {