mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

feat: promisify contentTracing.getCategories() (#16583)

Browse source 
* feat: promisify contentTracing.getCategories()

* deprecate contentTracing/getCategories
This commit is contained in:
Shelley Vohr 2019-01-30 12:39:55 -08:00 • committed by GitHub
parent 9ed89ace97
commit 641b47f384
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 32 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

20
atom/browser/api/atom_api_content_tracing.cc
View file

@ -8,6 +8,7 @@
#include "atom/common/native_mate_converters/callback.h"
#include "atom/common/native_mate_converters/file_path_converter.h"
#include "atom/common/native_mate_converters/value_converter.h"
#include "atom/common/promise_util.h"
#include "base/bind.h"
#include "base/files/file_util.h"
#include "content/public/browser/tracing_controller.h"
@ -71,11 +72,20 @@ void StopRecording(const base::FilePath& path,
GetTraceDataEndpoint(path, callback));
}
bool GetCategories(
const base::RepeatingCallback<void(const std::set<std::string>&)>&
callback) {
return TracingController::GetInstance()->GetCategories(
base::BindOnce(callback));
void OnCategoriesAvailable(scoped_refptr<atom::util::Promise> promise,
const std::set<std::string>& categories) {
promise->Resolve(categories);
}
v8::Local<v8::Promise> GetCategories(v8::Isolate* isolate) {
scoped_refptr<atom::util::Promise> promise = new atom::util::Promise(isolate);
bool success = TracingController::GetInstance()->GetCategories(
base::BindOnce(&OnCategoriesAvailable, promise));
if (!success)
promise->RejectWithErrorMessage("Could not get categories.");
return promise->GetHandle();
}
bool StartTracing(const base::trace_event::TraceConfig& trace_config,