mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

refactor: use associated v8::Context for event setup (#37355)

Browse source 
refactor: use associated v8::Context for event setup
This commit is contained in:
Shelley Vohr 2023-02-22 10:03:46 +01:00 • committed by GitHub
parent 32c60b29bb
commit 6395898a79
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
5 changed files with 6 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

5
shell/common/node_bindings.cc
View file

@ -415,7 +415,7 @@ void NodeBindings::SetNodeCliFlags() {
}
}
void NodeBindings::Initialize() {
void NodeBindings::Initialize(v8::Local<v8::Context> context) {
TRACE_EVENT0("electron", "NodeBindings::Initialize");
// Open node's error reporting system for browser process.
@ -463,8 +463,7 @@ void NodeBindings::Initialize() {
SetErrorMode(GetErrorMode() & ~SEM_NOGPFAULTERRORBOX);
#endif
v8::Isolate* isolate = v8::Isolate::GetCurrent();
gin_helper::internal::Event::GetConstructor(isolate->GetCurrentContext());
gin_helper::internal::Event::GetConstructor(context);
g_is_initialized = true;
}

2
shell/common/node_bindings.h
View file

@ -85,7 +85,7 @@ class NodeBindings {
virtual ~NodeBindings();
// Setup V8, libuv.
void Initialize();
void Initialize(v8::Local<v8::Context> context);
void SetNodeCliFlags();