mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

Add deprecation TODO for BrowserWindow.showDefinitionForSelection

Browse source
This commit is contained in:
Kevin Sawicki 2016-06-07 13:12:24 -07:00
parent ce19c2c0ad
commit 6360a5cae4
1 changed files with 2 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
atom/browser/native_window_mac.mm
View file

@ -934,6 +934,8 @@ void NativeWindowMac::SetOverlayIcon(const gfx::Image& overlay,
} }
void NativeWindowMac::ShowDefinitionForSelection() { void NativeWindowMac::ShowDefinitionForSelection() {
// TODO(kevinsawicki): Deprecate and remove this method in 2.0 in favor of
// calling it directly on webContents.
if (!web_contents()) if (!web_contents())
return; return;
auto rwhv = web_contents()->GetRenderWidgetHostView(); auto rwhv = web_contents()->GetRenderWidgetHostView();