mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

fix: systemMediaPermissionDenied should not check camera perms when the request is asking for screen share (#43517)

Browse source 
* fix: systemMediaPermissionDenied: should check for screen capture perms instead of camera

* Revert "fix: systemMediaPermissionDenied: should check for screen capture perms instead of camera"

This reverts commit e9cc67216558263402867056ed332f8781da3153.

* should only do these checks for audio or video, but not screenshare

* no service

* oops

---------

Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
This commit is contained in:
George Xu 2024-09-04 04:56:26 -04:00 • committed by GitHub
parent b42c0ae00d
commit 635d421123
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 3 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

5
shell/browser/web_contents_permission_helper.cc
View file

@ -57,7 +57,7 @@ namespace {
#if BUILDFLAG(IS_MAC) #if BUILDFLAG(IS_MAC)
bool SystemMediaPermissionDenied(const content::MediaStreamRequest& request) { bool SystemMediaPermissionDenied(const content::MediaStreamRequest& request) {
if (request.audio_type != MediaStreamType::NO_SERVICE) { if (request.audio_type == MediaStreamType::DEVICE_AUDIO_CAPTURE) {
const auto system_audio_permission = const auto system_audio_permission =
system_media_permissions::CheckSystemAudioCapturePermission(); system_media_permissions::CheckSystemAudioCapturePermission();
return system_audio_permission == return system_audio_permission ==
@ -65,7 +65,7 @@ bool SystemMediaPermissionDenied(const content::MediaStreamRequest& request) {
system_audio_permission == system_audio_permission ==
system_media_permissions::SystemPermission::kDenied; system_media_permissions::SystemPermission::kDenied;
} }
if (request.video_type != MediaStreamType::NO_SERVICE) { if (request.video_type == MediaStreamType::DEVICE_VIDEO_CAPTURE) {
const auto system_video_permission = const auto system_video_permission =
system_media_permissions::CheckSystemVideoCapturePermission(); system_media_permissions::CheckSystemVideoCapturePermission();
return system_video_permission == return system_video_permission ==
@ -73,6 +73,7 @@ bool SystemMediaPermissionDenied(const content::MediaStreamRequest& request) {
system_video_permission == system_video_permission ==
system_media_permissions::SystemPermission::kDenied; system_media_permissions::SystemPermission::kDenied;
} }
return false; return false;
} }
#endif #endif