mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

spec: don't run codesigning spec on forks (#19418)

Browse source
This commit is contained in:
Shelley Vohr 2019-07-24 10:55:16 -07:00 • committed by GitHub
parent 9dfc4eb2ff
commit 62e6957f68
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

4
spec-main/api-autoupdater-darwin-spec.ts
View file

@ -22,7 +22,9 @@ describeFn('autoUpdater behavior', function () {
beforeEach(function () { beforeEach(function () {
const result = cp.spawnSync(path.resolve(__dirname, '../script/codesign/get-trusted-identity.sh')) const result = cp.spawnSync(path.resolve(__dirname, '../script/codesign/get-trusted-identity.sh'))
if (result.status !== 0 || result.stdout.toString().trim().length === 0) { if (result.status !== 0 || result.stdout.toString().trim().length === 0) {
if (isCI) { // Per https://circleci.com/docs/2.0/env-vars:
// CIRCLE_PR_NUMBER is only present on forked PRs
if (isCI && !process.env.CIRCLE_PR_NUMBER) {
throw new Error('No valid signing identity available to run autoUpdater specs') throw new Error('No valid signing identity available to run autoUpdater specs')
} }
this.skip() this.skip()