mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

test: disable flaky <webview>.capturePage() specs (#41713)

Browse source 
test: disable flaky <webview>.capturePage() specs
This commit is contained in:
Shelley Vohr 2024-03-28 22:37:14 +01:00 • committed by GitHub
commit 62d4b21819
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 2 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

7
spec/webview-spec.ts
View file

@ -14,8 +14,6 @@ import { HexColors, ScreenCapture } from './lib/screen-helpers';
declare let WebView: any; declare let WebView: any;
const features = process._linkedBinding('electron_common_features'); const features = process._linkedBinding('electron_common_features');
const isMacArm64 = (process.platform === 'darwin' && process.arch === 'arm64');
async function loadWebView (w: WebContents, attributes: Record<string, string>, opts?: {openDevTools?: boolean}): Promise<void> { async function loadWebView (w: WebContents, attributes: Record<string, string>, opts?: {openDevTools?: boolean}): Promise<void> {
const { openDevTools } = { const { openDevTools } = {
openDevTools: false, openDevTools: false,
@ -2107,9 +2105,8 @@ describe('<webview> tag', function () {
} }
}); });
// TODO(miniak): figure out why this is failing on windows // FIXME: This test is flaking constantly on Linux and macOS.
// TODO(vertedinde): figure out why this is failing on mac arm64 xdescribe('<webview>.capturePage()', () => {
ifdescribe(process.platform !== 'win32' && !isMacArm64)('<webview>.capturePage()', () => {
it('returns a Promise with a NativeImage', async function () { it('returns a Promise with a NativeImage', async function () {
this.retries(5); this.retries(5);