mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

Fix test BrowserWindow.addTabbedWindow() (#11795)

Browse source 
* Fix test BrowserWindow.addTabbedWindow()

* Address review comments
This commit is contained in:
Nitish Sakhawalkar 2018-02-02 18:31:02 -08:00 • committed by Charles Kerr
parent bd06abd523
commit 62d2a3472f
1 changed files with 8 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

11
spec/api-browser-window-spec.js
View file

@ -703,8 +703,7 @@ describe('BrowserWindow module', () => {
}) })
}) })
// FIXME(alexeykuzmin): Fails on Mac. describe('BrowserWindow.addTabbedWindow()', () => {
xdescribe('BrowserWindow.addTabbedWindow()', () => {
before(function () { before(function () {
if (process.platform !== 'darwin') { if (process.platform !== 'darwin') {
this.skip() this.skip()
@ -716,7 +715,13 @@ describe('BrowserWindow module', () => {
assert.doesNotThrow(() => { assert.doesNotThrow(() => {
w.addTabbedWindow(tabbedWindow) w.addTabbedWindow(tabbedWindow)
}) })
closeWindow(tabbedWindow).then(done)
assert.equal(BrowserWindow.getAllWindows().length, 3) // Test window + w + tabbedWindow
closeWindow(tabbedWindow, {assertSingleWindow: false}).then(() => {
assert.equal(BrowserWindow.getAllWindows().length, 2) // Test window + w
done()
})
}) })
}) })