mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

perf: avoid redundant calls to GetView() (#43216)

Browse source 
* perf: avoid double-calls to GetView()

There are a lot of places where we call the virtual method GetView()
twice in succession: the first to check if the view exists, and the
second to use. This PR holds the view in a temp variable instead, e.g.:

if (auto* view = foo->GetView())
  view->DoSomething();

* perf: avoid discarded GetView() call
This commit is contained in:
Charles Kerr 2024-08-06 11:25:59 -05:00 • committed by GitHub
parent f42331f277
commit 6293bbced0
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
4 changed files with 20 additions and 28 deletions
Download patch file Download diff file Expand all files Collapse all files

5
shell/browser/api/frame_subscriber.cc
View file

@ -38,13 +38,14 @@ void FrameSubscriber::AttachToHost(content::RenderWidgetHost* host) {
// The view can be null if the renderer process has crashed.
// (https://crbug.com/847363)
if (!host_->GetView())
auto* rwhv = host_->GetView();
if (!rwhv)
return;
// Create and configure the video capturer.
gfx::Size size = GetRenderViewSize();
DCHECK(!size.IsEmpty());
video_capturer_ = host_->GetView()->CreateVideoCapturer();
video_capturer_ = rwhv->CreateVideoCapturer();
video_capturer_->SetResolutionConstraints(size, size, true);
video_capturer_->SetAutoThrottlingEnabled(false);
video_capturer_->SetMinSizeChangePeriod(base::TimeDelta());