mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

build: fix new TS linting errors (#17279)

Browse source 
* remove unused _args var
* handle type/variable shadowing
This commit is contained in:
Samuel Attard 2019-03-07 17:18:10 -08:00 • committed by GitHub
parent 2be62b1c33
commit 61fc95417b
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 12 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

8
lib/renderer/web-view/web-view-element.ts
View file

@ -9,7 +9,7 @@
// modules must be passed from outside, all included files must be plain JS.
import { WEB_VIEW_CONSTANTS } from '@electron/internal/renderer/web-view/web-view-constants'
import { WebViewImpl, webViewImplModule } from '@electron/internal/renderer/web-view/web-view-impl'
import { WebViewImpl as IWebViewImpl, webViewImplModule } from '@electron/internal/renderer/web-view/web-view-impl'
// Return a WebViewElement class that is defined in this context.
const defineWebViewElement = (v8Util: NodeJS.V8UtilBinding, webViewImpl: typeof webViewImplModule) => {
@ -41,7 +41,7 @@ const defineWebViewElement = (v8Util: NodeJS.V8UtilBinding, webViewImpl: typeof
}
connectedCallback () {
const internal = v8Util.getHiddenValue<WebViewImpl>(this, 'internal')
const internal = v8Util.getHiddenValue<IWebViewImpl>(this, 'internal')
if (!internal) {
return
}
@ -53,14 +53,14 @@ const defineWebViewElement = (v8Util: NodeJS.V8UtilBinding, webViewImpl: typeof
}
attributeChangedCallback (name: string, oldValue: any, newValue: any) {
const internal = v8Util.getHiddenValue<WebViewImpl>(this, 'internal')
const internal = v8Util.getHiddenValue<IWebViewImpl>(this, 'internal')
if (internal) {
internal.handleWebviewAttributeMutation(name, oldValue, newValue)
}
}
disconnectedCallback () {
const internal = v8Util.getHiddenValue<WebViewImpl>(this, 'internal')
const internal = v8Util.getHiddenValue<IWebViewImpl>(this, 'internal')
if (!internal) {
return
}