mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

refactor: ginify Menu (#22916)

Browse source
This commit is contained in:
Jeremy Apthorp 2020-04-02 16:07:56 -07:00 • committed by GitHub
parent 1d158399a6
commit 6159066c26
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
14 changed files with 241 additions and 150 deletions
Download patch file Download diff file Expand all files Collapse all files

10
spec-main/api-menu-item-spec.ts
View file

@ -48,7 +48,7 @@ describe('MenuItems', () => {
done();
}
}]);
menu.delegate.executeCommand(menu, {}, menu.items[0].commandId);
menu._executeCommand({}, menu.items[0].commandId);
});
});
@ -60,7 +60,7 @@ describe('MenuItems', () => {
}]);
expect(menu.items[0].checked).to.be.false('menu item checked');
menu.delegate.executeCommand(menu, {}, menu.items[0].commandId);
menu._executeCommand({}, menu.items[0].commandId);
expect(menu.items[0].checked).to.be.true('menu item checked');
});
@ -70,9 +70,9 @@ describe('MenuItems', () => {
type: 'radio'
}]);
menu.delegate.executeCommand(menu, {}, menu.items[0].commandId);
menu._executeCommand({}, menu.items[0].commandId);
expect(menu.items[0].checked).to.be.true('menu item checked');
menu.delegate.executeCommand(menu, {}, menu.items[0].commandId);
menu._executeCommand({}, menu.items[0].commandId);
expect(menu.items[0].checked).to.be.true('menu item checked');
});
@ -123,7 +123,7 @@ describe('MenuItems', () => {
it('at least have one item checked in each group', () => {
const menu = Menu.buildFromTemplate(template);
menu.delegate.menuWillShow(menu);
menu._menuWillShow();
const groups = findRadioGroups(template);