diff --git a/atom/browser/api/atom_api_browser_view.cc b/atom/browser/api/atom_api_browser_view.cc index c64054cdac2..82e13a385f4 100644 --- a/atom/browser/api/atom_api_browser_view.cc +++ b/atom/browser/api/atom_api_browser_view.cc @@ -68,8 +68,8 @@ void BrowserView::Init(v8::Isolate* isolate, web_contents_.Reset(isolate, web_contents.ToV8()); api_web_contents_ = web_contents.get(); - view_.reset(NativeBrowserView::Create( - api_web_contents_->managed_web_contents()->GetView())); + view_.reset( + NativeBrowserView::Create(api_web_contents_->managed_web_contents())); InitWith(isolate, wrapper); } diff --git a/atom/browser/native_browser_view.cc b/atom/browser/native_browser_view.cc index c97fe683e6c..4fd5889597b 100644 --- a/atom/browser/native_browser_view.cc +++ b/atom/browser/native_browser_view.cc @@ -7,14 +7,19 @@ #include "atom/browser/native_browser_view.h" #include "atom/browser/api/atom_api_web_contents.h" -#include "brightray/browser/inspectable_web_contents_view.h" +#include "brightray/browser/inspectable_web_contents.h" namespace atom { NativeBrowserView::NativeBrowserView( - brightray::InspectableWebContentsView* web_contents_view) - : web_contents_view_(web_contents_view) {} + brightray::InspectableWebContents* inspectable_web_contents) + : inspectable_web_contents_(inspectable_web_contents) {} NativeBrowserView::~NativeBrowserView() {} +brightray::InspectableWebContentsView* +NativeBrowserView::GetInspectableWebContentsView() { + return inspectable_web_contents_->GetView(); +} + } // namespace atom diff --git a/atom/browser/native_browser_view.h b/atom/browser/native_browser_view.h index 7c154b60b00..b58af0fd834 100644 --- a/atom/browser/native_browser_view.h +++ b/atom/browser/native_browser_view.h @@ -12,6 +12,7 @@ #include "third_party/skia/include/core/SkColor.h" namespace brightray { +class InspectableWebContents; class InspectableWebContentsView; } @@ -31,12 +32,14 @@ class NativeBrowserView { virtual ~NativeBrowserView(); static NativeBrowserView* Create( - brightray::InspectableWebContentsView* web_contents_view); + brightray::InspectableWebContents* inspectable_web_contents); - brightray::InspectableWebContentsView* GetInspectableWebContentsView() { - return web_contents_view_; + brightray::InspectableWebContents* GetInspectableWebContents() { + return inspectable_web_contents_; } + brightray::InspectableWebContentsView* GetInspectableWebContentsView(); + virtual void SetAutoResizeFlags(uint8_t flags) = 0; virtual void SetBounds(const gfx::Rect& bounds) = 0; virtual void SetBackgroundColor(SkColor color) = 0; @@ -47,9 +50,9 @@ class NativeBrowserView { protected: explicit NativeBrowserView( - brightray::InspectableWebContentsView* web_contents_view); + brightray::InspectableWebContents* inspectable_web_contents); - brightray::InspectableWebContentsView* web_contents_view_; + brightray::InspectableWebContents* inspectable_web_contents_; private: DISALLOW_COPY_AND_ASSIGN(NativeBrowserView); diff --git a/atom/browser/native_browser_view_mac.h b/atom/browser/native_browser_view_mac.h index 0b04edad729..726ca75433e 100644 --- a/atom/browser/native_browser_view_mac.h +++ b/atom/browser/native_browser_view_mac.h @@ -17,12 +17,13 @@ namespace atom { class NativeBrowserViewMac : public NativeBrowserView { public: explicit NativeBrowserViewMac( - brightray::InspectableWebContentsView* web_contents_view); + brightray::InspectableWebContents* inspectable_web_contents); ~NativeBrowserViewMac() override; void SetAutoResizeFlags(uint8_t flags) override; void SetBounds(const gfx::Rect& bounds) override; void SetBackgroundColor(SkColor color) override; + void UpdateDraggableRegions( const std::vector& system_drag_exclude_areas) override; diff --git a/atom/browser/native_browser_view_mac.mm b/atom/browser/native_browser_view_mac.mm index 17b0a1ee900..9634f20f982 100644 --- a/atom/browser/native_browser_view_mac.mm +++ b/atom/browser/native_browser_view_mac.mm @@ -4,6 +4,7 @@ #include "atom/browser/native_browser_view_mac.h" +#include "brightray/browser/inspectable_web_contents.h" #include "brightray/browser/inspectable_web_contents_view.h" #include "skia/ext/skia_utils_mac.h" #include "ui/gfx/geometry/rect.h" @@ -156,8 +157,8 @@ const NSAutoresizingMaskOptions kDefaultAutoResizingMask = namespace atom { NativeBrowserViewMac::NativeBrowserViewMac( - brightray::InspectableWebContentsView* web_contents_view) - : NativeBrowserView(web_contents_view) { + brightray::InspectableWebContents* inspectable_web_contents) + : NativeBrowserView(inspectable_web_contents) { auto* view = GetInspectableWebContentsView()->GetNativeView(); view.autoresizingMask = kDefaultAutoResizingMask; } @@ -247,8 +248,8 @@ void NativeBrowserViewMac::UpdateDraggableRegions( // static NativeBrowserView* NativeBrowserView::Create( - brightray::InspectableWebContentsView* web_contents_view) { - return new NativeBrowserViewMac(web_contents_view); + brightray::InspectableWebContents* inspectable_web_contents) { + return new NativeBrowserViewMac(inspectable_web_contents); } } // namespace atom diff --git a/atom/browser/native_browser_view_views.cc b/atom/browser/native_browser_view_views.cc index 78e788b3019..def64d12e35 100644 --- a/atom/browser/native_browser_view_views.cc +++ b/atom/browser/native_browser_view_views.cc @@ -12,8 +12,8 @@ namespace atom { NativeBrowserViewViews::NativeBrowserViewViews( - brightray::InspectableWebContentsView* web_contents_view) - : NativeBrowserView(web_contents_view) {} + brightray::InspectableWebContents* inspectable_web_contents) + : NativeBrowserView(inspectable_web_contents) {} NativeBrowserViewViews::~NativeBrowserViewViews() {} @@ -29,8 +29,8 @@ void NativeBrowserViewViews::SetBackgroundColor(SkColor color) { // static NativeBrowserView* NativeBrowserView::Create( - brightray::InspectableWebContentsView* web_contents_view) { - return new NativeBrowserViewViews(web_contents_view); + brightray::InspectableWebContents* inspectable_web_contents) { + return new NativeBrowserViewViews(inspectable_web_contents); } } // namespace atom diff --git a/atom/browser/native_browser_view_views.h b/atom/browser/native_browser_view_views.h index 5dcda13447c..abf47178302 100644 --- a/atom/browser/native_browser_view_views.h +++ b/atom/browser/native_browser_view_views.h @@ -12,7 +12,7 @@ namespace atom { class NativeBrowserViewViews : public NativeBrowserView { public: explicit NativeBrowserViewViews( - brightray::InspectableWebContentsView* web_contents_view); + brightray::InspectableWebContents* inspectable_web_contents); ~NativeBrowserViewViews() override; uint8_t GetAutoResizeFlags() { return auto_resize_flags_; }