mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

test: unflake some focus tests (#34061)

Browse source 
* spec: unflake some focus tests

* test: disable flaky webFrame visibiilty spec
This commit is contained in:
Samuel Attard 2022-05-04 01:29:30 -07:00 • committed by GitHub
parent 349cd98b0a
commit 60f1e5e008
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 8 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

10
spec-main/api-browser-window-spec.ts
View file

@ -694,12 +694,12 @@ describe('BrowserWindow module', () => {
}); });
describe('BrowserWindow.show()', () => { describe('BrowserWindow.show()', () => {
it('should focus on window', () => { it('should focus on window', async () => {
w.show(); await emittedOnce(w, 'focus', () => w.show());
expect(w.isFocused()).to.equal(true); expect(w.isFocused()).to.equal(true);
}); });
it('should make the window visible', () => { it('should make the window visible', async () => {
w.show(); await emittedOnce(w, 'focus', () => w.show());
expect(w.isVisible()).to.equal(true); expect(w.isVisible()).to.equal(true);
}); });
it('emits when window is shown', async () => { it('emits when window is shown', async () => {
@ -895,7 +895,7 @@ describe('BrowserWindow module', () => {
describe('BrowserWindow.getFocusedWindow()', () => { describe('BrowserWindow.getFocusedWindow()', () => {
it('returns the opener window when dev tools window is focused', async () => { it('returns the opener window when dev tools window is focused', async () => {
w.show(); await emittedOnce(w, 'focus', () => w.show());
w.webContents.openDevTools({ mode: 'undocked' }); w.webContents.openDevTools({ mode: 'undocked' });
await emittedOnce(w.webContents, 'devtools-focused'); await emittedOnce(w.webContents, 'devtools-focused');
expect(BrowserWindow.getFocusedWindow()).to.equal(w); expect(BrowserWindow.getFocusedWindow()).to.equal(w);

4
spec-main/api-web-frame-main-spec.ts
View file

@ -137,7 +137,9 @@ describe('webFrameMain module', () => {
}); });
describe('WebFrame.visibilityState', () => { describe('WebFrame.visibilityState', () => {
it('should match window state', async () => { // TODO(MarshallOfSound): Fix flaky test
// @flaky-test
it.skip('should match window state', async () => {
const w = new BrowserWindow({ show: true }); const w = new BrowserWindow({ show: true });
await w.loadURL('about:blank'); await w.loadURL('about:blank');
const webFrame = w.webContents.mainFrame; const webFrame = w.webContents.mainFrame;