mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

Remove the isolate parameter of GetWrapper

Browse source
This commit is contained in:
Cheng Zhao 2016-04-25 10:19:25 +09:00
parent 2ae52d0ff4
commit 60d2cb8a84
3 changed files with 5 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

6
atom/browser/api/event_emitter.h
View file

@ -41,9 +41,7 @@ class EventEmitter : public Wrappable<T> {
// Make the convinient methods visible:
// https://isocpp.org/wiki/faq/templates#nondependent-name-lookup-members
v8::Local<v8::Object> GetWrapper(v8::Isolate* isolate = nullptr) {
return Wrappable<T>::GetWrapper();
}
v8::Local<v8::Object> GetWrapper() { return Wrappable<T>::GetWrapper(); }
v8::Isolate* isolate() const { return Wrappable<T>::isolate(); }
// this.emit(name, event, args...);
@ -86,7 +84,7 @@ class EventEmitter : public Wrappable<T> {
const Args&... args) {
v8::Locker locker(isolate());
v8::HandleScope handle_scope(isolate());
EmitEvent(isolate(), GetWrapper(isolate()), name, event, args...);
EmitEvent(isolate(), GetWrapper(), name, event, args...);
return event->Get(
StringToV8(isolate(), "defaultPrevented"))->BooleanValue();
}