mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

Don't allow duplicate object in a parsed array

Browse source 
This feature was introduced to fix #874 but caused the converter to go
through a deep nested object sometimes, which made program crash on
Windows. So we have to revert the fix even though it makes a regression.

Fixes atom/atom#4904.
This commit is contained in:
Cheng Zhao 2015-01-07 23:20:03 -08:00
parent 640c8f88ff
commit 609e3ec3ff
2 changed files with 1 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

5
atom/common/native_mate_converters/v8_value_converter.cc
View file

@ -294,10 +294,7 @@ base::Value* V8ValueConverter::FromV8Array(
if (!val->HasRealIndexedProperty(i))
continue;
// When parsing elements in an array, we use a new state so we can have the
// same object showed twice in array.
FromV8ValueState new_state;
base::Value* child = FromV8ValueImpl(&new_state, child_v8, isolate);
base::Value* child = FromV8ValueImpl(state, child_v8, isolate);
if (child)
result->Append(child);
else