mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

build: use proper targets for building (#43588)

Browse source 
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
This commit is contained in:
trop[bot] 2024-09-06 12:07:55 +02:00 committed by GitHub
parent b31a4dcdf3
commit 60264f30d8
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 9 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
.github/actions/build-electron/action.yml vendored
View file

@ -69,7 +69,7 @@ runs:
shell: bash shell: bash
run: | run: |
cd src cd src
e build electron:electron_dist_zip -j $NUMBER_OF_NINJA_PROCESSES e build --target electron:electron_dist_zip -j $NUMBER_OF_NINJA_PROCESSES
if [ "${{ inputs.is-asan }}" != "true" ]; then if [ "${{ inputs.is-asan }}" != "true" ]; then
target_os=${{ inputs.target-platform == 'linux' && 'linux' || 'mac'}} target_os=${{ inputs.target-platform == 'linux' && 'linux' || 'mac'}}
if [ "${{ inputs.artifact-platform }}" = "mas" ]; then if [ "${{ inputs.artifact-platform }}" = "mas" ]; then
@ -81,7 +81,7 @@ runs:
shell: bash shell: bash
run: | run: |
cd src cd src
e build electron:electron_mksnapshot -j $NUMBER_OF_NINJA_PROCESSES e build --target electron:electron_mksnapshot -j $NUMBER_OF_NINJA_PROCESSES
gn desc out/Default v8:run_mksnapshot_default args > out/Default/mksnapshot_args gn desc out/Default v8:run_mksnapshot_default args > out/Default/mksnapshot_args
# Remove unused args from mksnapshot_args # Remove unused args from mksnapshot_args
SEDOPTION="-i" SEDOPTION="-i"
@ -104,7 +104,7 @@ runs:
fi fi
fi fi
e build electron:electron_mksnapshot_zip -j $NUMBER_OF_NINJA_PROCESSES e build --target electron:electron_mksnapshot_zip -j $NUMBER_OF_NINJA_PROCESSES
(cd out/Default; zip mksnapshot.zip mksnapshot_args gen/v8/embedded.S) (cd out/Default; zip mksnapshot.zip mksnapshot_args gen/v8/embedded.S)
- name: Generate Cross-Arch Snapshot (arm/arm64) ${{ inputs.step-suffix }} - name: Generate Cross-Arch Snapshot (arm/arm64) ${{ inputs.step-suffix }}
shell: bash shell: bash
@ -130,24 +130,24 @@ runs:
shell: bash shell: bash
run: | run: |
cd src cd src
e build electron:electron_chromedriver -j $NUMBER_OF_NINJA_PROCESSES e build --target electron:electron_chromedriver -j $NUMBER_OF_NINJA_PROCESSES
e build electron:electron_chromedriver_zip e build --target electron:electron_chromedriver_zip
- name: Build Node.js headers ${{ inputs.step-suffix }} - name: Build Node.js headers ${{ inputs.step-suffix }}
shell: bash shell: bash
run: | run: |
cd src cd src
e build electron:node_headers e build --target electron:node_headers
- name: Generate & Zip Symbols ${{ inputs.step-suffix }} - name: Generate & Zip Symbols ${{ inputs.step-suffix }}
shell: bash shell: bash
run: | run: |
# Generate breakpad symbols on release builds # Generate breakpad symbols on release builds
if [ "${{ inputs.generate-symbols }}" = "true" ]; then if [ "${{ inputs.generate-symbols }}" = "true" ]; then
e build electron:electron_symbols e build --target electron:electron_symbols
fi fi
cd src cd src
export BUILD_PATH="$(pwd)/out/Default" export BUILD_PATH="$(pwd)/out/Default"
e build electron:licenses e build --target electron:licenses
e build electron:electron_version_file e build --target electron:electron_version_file
if [ "${{ inputs.is-release }}" = "true" ]; then if [ "${{ inputs.is-release }}" = "true" ]; then
DELETE_DSYMS_AFTER_ZIP=1 electron/script/zip-symbols.py -b $BUILD_PATH DELETE_DSYMS_AFTER_ZIP=1 electron/script/zip-symbols.py -b $BUILD_PATH
else else