mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix: generate breakpad symbols before stripping (#20530)

Browse source 
* fix: generate breakpad symbols before stripping

* store symbols as circleci artifacts
This commit is contained in:
Jeremy Apthorp 2019-10-14 07:58:05 -07:00 committed by John Kleinschmidt
parent 8efa45d12d
commit 6025ae7b12
1 changed files with 9 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
.circleci/config.yml
View file

@ -553,6 +553,11 @@ step-maybe-zip-symbols: &step-maybe-zip-symbols
ninja -C out/Default electron:electron_version ninja -C out/Default electron:electron_version
electron/script/zip-symbols.py -b $BUILD_PATH electron/script/zip-symbols.py -b $BUILD_PATH
step-symbols-store: &step-symbols-store
store_artifacts:
path: src/out/Default/symbols.zip
destination: symbols.zip
step-maybe-cross-arch-snapshot: &step-maybe-cross-arch-snapshot step-maybe-cross-arch-snapshot: &step-maybe-cross-arch-snapshot
run: run:
name: Generate cross arch snapshot (arm/arm64) name: Generate cross arch snapshot (arm/arm64)
@ -859,6 +864,7 @@ steps-electron-build: &steps-electron-build
- *step-maybe-generate-breakpad-symbols - *step-maybe-generate-breakpad-symbols
- *step-maybe-zip-symbols - *step-maybe-zip-symbols
- *step-symbols-store
# Trigger tests on arm hardware if needed # Trigger tests on arm hardware if needed
- *step-maybe-trigger-arm-test - *step-maybe-trigger-arm-test
@ -933,6 +939,7 @@ steps-electron-build-with-inline-checkout-for-tests: &steps-electron-build-with-
- *step-maybe-generate-breakpad-symbols - *step-maybe-generate-breakpad-symbols
- *step-maybe-zip-symbols - *step-maybe-zip-symbols
- *step-symbols-store
# Trigger tests on arm hardware if needed # Trigger tests on arm hardware if needed
- *step-maybe-trigger-arm-test - *step-maybe-trigger-arm-test
@ -953,11 +960,12 @@ steps-electron-build-for-publish: &steps-electron-build-for-publish
# Electron app # Electron app
- *step-electron-build - *step-electron-build
- *step-maybe-generate-breakpad-symbols
- *step-maybe-electron-dist-strip - *step-maybe-electron-dist-strip
- *step-electron-dist-build - *step-electron-dist-build
- *step-electron-dist-store - *step-electron-dist-store
- *step-maybe-generate-breakpad-symbols
- *step-maybe-zip-symbols - *step-maybe-zip-symbols
- *step-symbols-store
# mksnapshot # mksnapshot
- *step-mksnapshot-build - *step-mksnapshot-build