mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

perf: build g_dgettext domain name at compile time (#43986)

Browse source 
perf: build GettextPackage name at compile time

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
This commit is contained in:
trop[bot] 2024-09-26 18:59:06 -05:00 committed by GitHub
parent 514fc26eb2
commit 6010fda0c7
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 7 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
shell/browser/ui/gtk_util.cc
View file

@ -8,16 +8,12 @@
#include <gtk/gtk.h> #include <gtk/gtk.h>
#include <stdint.h> #include <stdint.h>
#include <string> #include "base/macros/remove_parens.h"
#include <vector> #include "base/strings/stringize_macros.h"
#include "base/no_destructor.h"
#include "base/strings/string_number_conversions.h"
#include "electron/electron_gtk_stubs.h" #include "electron/electron_gtk_stubs.h"
#include "third_party/skia/include/core/SkBitmap.h" #include "third_party/skia/include/core/SkBitmap.h"
#include "third_party/skia/include/core/SkColor.h" #include "third_party/skia/include/core/SkColor.h"
#include "third_party/skia/include/core/SkUnPreMultiply.h" #include "third_party/skia/include/core/SkUnPreMultiply.h"
#include "ui/gtk/gtk_compat.h" // nogncheck
// The following utilities are pulled from // The following utilities are pulled from
// https://source.chromium.org/chromium/chromium/src/+/main:ui/gtk/select_file_dialog_linux_gtk.cc;l=44-75;drc=a03ba4ca94f75531207c3ea832d6a605cde77394 // https://source.chromium.org/chromium/chromium/src/+/main:ui/gtk/select_file_dialog_linux_gtk.cc;l=44-75;drc=a03ba4ca94f75531207c3ea832d6a605cde77394
@ -25,14 +21,12 @@ namespace gtk_util {
namespace { namespace {
const char* GettextPackage() {
static base::NoDestructor<std::string> gettext_package(
"gtk" + base::NumberToString(gtk::GtkVersion().components()[0]) + "0");
return gettext_package->c_str();
}
const char* GtkGettext(const char* str) { const char* GtkGettext(const char* str) {
return g_dgettext(GettextPackage(), str); // ex: "gtk30". GTK_MAJOR_VERSION is #defined as an int in parenthesis,
// like (3), so use base macros to remove parenthesis and stringize it
static const char kGettextDomain[] =
"gtk" STRINGIZE(BASE_REMOVE_PARENS(GTK_MAJOR_VERSION)) "0";
return g_dgettext(kGettextDomain, str);
} }
} // namespace } // namespace